Enable Windows tests on GH Actions (#2391)

* Enable Windows CI

* WIP

* Move to chaiMatchPattern

* Linting

* More Windows tweaks

* globby changes

* Just run test-node

* gulp build

.github/workflows/pull-request.yml

@@ -3,25 +3,29 @@ name: Test Suite
 on: [pull_request]
 
 jobs:
-  # Node_Tests_Windows:
-  #   runs-on: windows-latest
+  Node_Tests_Windows:
+    runs-on: windows-latest
 
-  #   steps:
-  #   - uses: actions/checkout@v2
+    steps:
+    - uses: actions/checkout@v2
 
-  #   - uses: actions/cache@v1
-  #     with:
-  #       path: ~/.npm
-  #       key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-  #       restore-keys: |
-  #         ${{ runner.os }}-node-
+    - uses: actions/cache@v1
+      with:
+        path: ~/.npm
+        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+        restore-keys: |
+          ${{ runner.os }}-node-
           
-  #   - uses: actions/setup-node@v1
-  #     with:
-  #       node-version: 13.x
+    - uses: actions/setup-node@v1
+      with:
+        node-version: 13.x
+
+    - name: Setup
+      run: |
+        npm ci
+        gulp build
 
-  #   - run: npm ci
-  #   - run: npx gulp test
+    - run: npx gulp test-node
 
   Full_Suite_Mac:
     runs-on: macos-latest

infra/testing/validator/service-worker-runtime.js

@@ -7,42 +7,21 @@
 */
 
 const assert = require('assert');
-const expect = require('chai').expect;
+const chai = require('chai');
+const chaiMatchPattern = require('chai-match-pattern');
 const fse = require('fs-extra');
 const makeServiceWorkerEnv = require('service-worker-mock');
 const sinon = require('sinon');
 const vm = require('vm');
 
+chai.use(chaiMatchPattern);
+const {expect} = chai;
+
 // See https://github.com/chaijs/chai/issues/697
 function stringifyFunctionsInArray(arr) {
   return arr.map((item) => typeof item === 'function' ? item.toString() : item);
 }
 
-function validatePrecacheAndRoute({actual, expected}) {
-  for (const call of actual) {
-    for (const manifestEntry of call[0]) {
-      if (/[0-9a-f]{32}/.test(manifestEntry.revision)) {
-        manifestEntry.revision = '32_CHARACTER_HASH';
-      }
-
-      if (manifestEntry.url) {
-        manifestEntry.url = manifestEntry.url.replace(/[0-9a-f]{20}/, '20_CHARACTER_HASH');
-      }
-    }
-  }
-
-  expect(actual).to.deep.equal(expected);
-}
-
-function validateImportScripts({actual, expected}) {
-  for (let i = 0; i < actual.length; i++) {
-    actual[i] = actual[i].map((script) => script.replace(/[0-9a-f]{20}/, '20_CHARACTER_HASH'));
-    actual[i] = actual[i].map((script) => script.replace(/[0-9a-f]{8}/, '8_CHARACTER_HASH'));
-  }
-
-  expect(actual).to.deep.equal(expected);
-}
-
 function setupSpiesAndContextForInjectManifest() {
   const cacheableResponsePluginSpy = sinon.spy();
   class CacheableResponsePlugin {
@@ -166,20 +145,7 @@ function validateMethodCalls({methodsToSpies, expectedMethodCalls, context}) {
       const args = spy.args.map(
           (arg) => Array.isArray(arg) ? stringifyFunctionsInArray(arg) : arg);
 
-      if (method === 'precacheAndRoute') {
-        validatePrecacheAndRoute({
-          actual: args,
-          expected: expectedMethodCalls.precacheAndRoute,
-        });
-      } else if (method === 'importScripts') {
-        validateImportScripts({
-          actual: args,
-          expected: expectedMethodCalls.importScripts,
-        });
-      } else {
-        expect(args).to.deep.equal(expectedMethodCalls[method],
-            `while testing method calls for ${method}`);
-      }
+      expect(args).to.matchPattern(expectedMethodCalls[method]);
     } else {
       expect(expectedMethodCalls[method],
           `while testing method calls for ${method}`).to.be.undefined;

package.json

@@ -62,6 +62,7 @@
     "bytes": "^3.1.0",
     "camelcase": "^5.3.1",
     "chai": "^4.2.0",
+    "chai-match-pattern": "^1.1.0",
     "chalk": "^3.0.0",
     "clear-require": "^3.0.0",
     "comlinkjs": "^3.2.0",