This repository has been archived by the owner on Oct 6, 2022. It is now read-only.
fix: clean errors, add validation & reduce exposed #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
samuelli
suggested changes
Aug 30, 2017
src/main.js
Outdated
| } | ||
| }); | ||
|
|
||
| app.get('/_ah/health', (request, response) => response.send('OK')); | ||
|
|
||
| app.get('/_ah/stop', async(request, response) => { | ||
| // only expose chrome disable in development |
There was a problem hiding this comment.
Let's just remove /_ah/stop entirely.
test/app-test.js
Outdated
| const testBase = 'http://localhost:1234/'; | ||
| process.env.NODE_ENV = 'development'; |
src/main.js
Outdated
| const CONFIG_PATH = path.resolve(__dirname, '../config.json'); | ||
| const PROGRESS_BAR_PATH = path.resolve(__dirname, '../node_modules/progress-bar-element/progress-bar.html'); | ||
| const PORT = process.env.PORT || '3000'; | ||
| const ENVIRONMENT = process.env.NODE_ENV; |
There was a problem hiding this comment.
Remove per below comment.
test/app-test.js
Outdated
| @@ -39,8 +47,8 @@ test.before(async(t) => { | |||
| async function createServer(config) { | |||
| delete require.cache[require.resolve('../src/main.js')]; | |||
| const app = await require('../src/main.js'); | |||
| if (config) | |||
| app.setConfig(config); | |||
| if (config) app.setConfig(config); | |||
There was a problem hiding this comment.
Can we leave this on a separate line please?
test/app-test.js
Outdated
| if (config) | ||
| app.setConfig(config); | ||
| if (config) app.setConfig(config); | ||
| await appInstances.push(app); |
|
Covered the changes requested in the latest commit |
samuelli
approved these changes
Aug 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues listed below:
/_ah/stopifNODE_ENVis set todevelopmentprogress-bar.htmlused in application