fix off-by-one error causing Infinity in 100% EIL #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we may be good after this and #546 to do a new extension release. I'm not seeing any other issues right now. |
|
Nice work debugging this guy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the remaining extension issues—occasional infinite loading spinner on the report page.
The conditional for the EIL calc loop was sometimes going one higher than it should due to floating point issues. This would only affect the 100th percentile result (so wasn't used in any calculations (yet)), but would end up putting an
Infinityin theextendedInfodue to a divide by 0. It then wasJSON.stringifyed andJSON.parsed, which roundtripsInfinitytonull, thus giving theTypeError: Cannot read property 'toFixed' of nullexception causing the infinite spinner.