Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(util): fix formatDuration, add tests #5023

Merged
merged 2 commits into from
Apr 24, 2018
Merged

report(util): fix formatDuration, add tests #5023

merged 2 commits into from
Apr 24, 2018

Conversation

patrickhulce
Copy link
Collaborator

noticed the displays strings broken while looking at #5009

brendankenny
brendankenny approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needed updated golden LHR.

Waiting on travis now.

@brendankenny brendankenny merged commit ad3ebf5 into master Apr 24, 2018
@brendankenny brendankenny deleted the fix_cache_lifetime branch April 24, 2018 21:17
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@patrickhulce @kdzwinel
report(util): fix formatDuration, add tests (GoogleChrome#5023)
2573e82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny brendankenny approved these changes

@vinamratasingal-zz vinamratasingal-zz Awaiting requested review from vinamratasingal-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhulce @paulirish @brendankenny @devtools-bot