Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): generate API docs from source #3611

Closed

Conversation

manekinekko
Copy link

FIX #2463

The generated documentation looks like this:
image

You can generate the api doc using the npm command: npm run generate-docs

I set the output folder in docs/api (this is configurable in .jsdoc.json)

However, it seems that some jsdocs comments are valid like this:

ERROR: Unable to parse a tag's type expression for source file 
lighthouse/lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js in line 181 with tag title "return" and text "{!Promise<!Array<!Object>}": Invalid type expression "!Promise<!Array<!Object>": Expected ",", "=", ">" or "|" but end of input found.

TBH, I'm not familiar with this syntax. any idea how to fix this?

@patrickhulce
Copy link
Collaborator

WOW thanks @manekinekko!! the error you're getting is from some of our invalid closure types, just missing a > :)

@paulirish
Copy link
Member

I just staged this up on my gh-pages: http://paulirish.github.io/lighthouse/docs/api/lighthouse/2.5.1/

@paulirish
Copy link
Member

Thanks very much for doing this.

After some discussion we're not going to include this. Some of our recent typing work will definitely assist with the goals of #2463

Cheers!

@paulirish paulirish closed this Apr 5, 2018
@manekinekko
Copy link
Author

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate html API docs for artifacts, driver, etc
3 participants