improve typescript declaration imports #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this make a bare typescript import just work? |
|
If you rename chrome-launcher.ts to index.ts it would also work, no need to add an extra file. Tested it locally. Still requires the package.json change. |
|
cool cool. @pedro93 with a bunch of index.ts/js files in the project as it makes it harder to navigate, so that's why i favor this pattern a bit more. :) |
This was referenced Jun 16, 2017
paulirish
added a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thx @devrelm for the suggestion
fixes #2497
ref #1773