Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running the extension inside an incognito window does not open generated report #1177

Closed
TimvdLippe opened this issue Dec 19, 2016 · 5 comments · Fixed by #2734
Closed

Running the extension inside an incognito window does not open generated report #1177

TimvdLippe opened this issue Dec 19, 2016 · 5 comments · Fixed by #2734
Labels
bug extension report

Comments

@TimvdLippe
Copy link
Contributor

Running Lighthouse on a website in an incognito window, when the extension generated it opens a new tab with an URL such as blob:chrome-extension://<EXTENSION-ID>/<REPORT-ID>. However, incognito disallows accessing this output and displays a HTTP ERROR 404 page. Consequently copying the URL back into a normal Chrome window does show the correct report.

I run Lighthouse inside an incognito window because I have other extensions running that I do not want to interfere with my performance tests.
@ebidel
Copy link
Contributor

ebidel commented Dec 19, 2016

Another reason to possibly switch away from blob urls is that we never revoke them. From multiple runs of LH:

screen shot 2016-12-19 at 8 49 24 am

Perhaps we can put a close handler onbeforeunload that calls URL.revokeObjectURL. Although if you load that URL again, you'd expect it to still work.

patrickhulce added a commit that referenced this issue Dec 19, 2016
@patrickhulce
fix: Promise polyfill for zone
44a634f 
Fixes evaluateAsync behavior when [zone.js](https://github.com/angular/zone.js) has mucked with Promise.
Adds zone.js to the smoke tests so regression won't happen again.

Addresses #1177.
@patrickhulce patrickhulce mentioned this issue Dec 19, 2016
Merged
@TimvdLippe
Copy link
Contributor Author

@patrickhulce Your PR mentioned this issue and it has been merged. Does that mean this issue has been resolved and can be closed? Thanks for your work!

@ebidel
Copy link
Contributor

ebidel commented Dec 30, 2016 •
edited
Loading

This one is still open. That PR was meant for #1173

@Krinkle
Copy link

Krinkle commented Feb 21, 2017

Still reproducible on Chrome 58.0.3016.0 canary with Lighthouse extension 1.5.2. Enabling it in Incognito performs the whole run and then opens a second tab with a blob url that leads to a 404 error.

@pavelloz
Copy link

Bug still present in Lighthouse 2.2.1 @ Chrome 59, OSX

@brendankenny brendankenny mentioned this issue Jul 24, 2017
Merged
@brendankenny brendankenny mentioned this issue Sep 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug extension report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

open extension's report in new window GoogleChrome/lighthouse
5 participants
@Krinkle @ebidel @pavelloz @wardpeet @TimvdLippe