Add a report on external review status #3819
Conversation
| * @returns {number} | ||
| */ | ||
| function compareOutstandingReview(a, b) { | ||
| console.assert(a.current_stage === b.current_stage); |
There was a problem hiding this comment.
Is this console.assert needed?
There was a problem hiding this comment.
I think I'd like to either keep it or turn it into an exception, although I'll add a better error message. The function doesn't do a reasonable sort on features whose current stages are different, so if the code ever changes to ask it to, we should notice that somehow. I lean toward a console message rather than an exception, because a bad sort doesn't make the page useless, and an exception probably would.
| : nothing | ||
| ), | ||
| error: e => { | ||
| console.error(e); |
There was a problem hiding this comment.
Do you want to keep this console.error?
There was a problem hiding this comment.
Yes, since this branch results in a useless page, and people who encounter it should have a message they can paste to us in their bug report. But I should give it a better error message.
There's a circular dependency in the generated openapi javascript, which is very similar to the one in OpenAPITools/openapi-generator#6140 but caused by using the
discriminatorfield in theLinkPreviewobject. It doesn't appear to cause any concrete problems other than a warning during rollup, but I've sent OpenAPITools/openapi-generator#18503 to fix it in their repository.Screenshot of the WebKit report:
