New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FindLastIndex function to iterate over the entire slice #48

Merged

Goldziher merged 1 commit into Goldziher:main from dan1elhughes:bugfix/findlastindex-first-position

May 19, 2024

Contributor

dan1elhughes commented May 17, 2024

FindLastIndex wasn't finding the index if the matching element was in position zero due to an i > 0 iteration condition that should be i >= 0.

Added a test case that fails without this fix.


          Fix FindLastIndex function to iterate over the entire slice

57c78c7

Goldziher approved these changes

View reviewed changes

Goldziher merged commit 6720fe2 into Goldziher:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet