Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Instrumentation Test: TransactionsActivityTest#testAddMultiCurrencyTransaction #26

Closed
djbrown opened this issue Jun 1, 2023 · 1 comment
Closed

Failing Instrumentation Test: TransactionsActivityTest#testAddMultiCurrencyTransaction #26

djbrown opened this issue Jun 1, 2023 · 1 comment
Labels
type/regression

Comments

@djbrown
Copy link

djbrown commented Jun 1, 2023 •
edited
Loading

Steps to reproduce the behaviour

Run TransactionsActivityTest#testAddMultiCurrencyTransaction on recent test configuration (e.g. Pixel 7 API 33).
See CI Builds for Instrumentation Reports.
See also #25 for other confirmed configurations.

Expected behaviour

Test should pass.

Actual behaviour

Test fails with follwing error:

java.lang.AssertionError: 
Expecting:
 <["transactions-account", "transfer_account"]>
to contain:
 <["beb877ec08944dba8c335cbf899aa30d"]>
but could not find:
 <["beb877ec08944dba8c335cbf899aa30d"]>

	at org.gnucash.android.test.ui.TransactionsActivityTest.testAddMultiCurrencyTransaction(TransactionsActivityTest.java:330)

Software specifications

  • System Android version: API level 33
  • Device type: Pixel 7

Suggested Resolution
@djbrown djbrown mentioned this issue Jun 1, 2023
Open
19 tasks
reul added a commit to reul/gnucash-android that referenced this issue Jun 3, 2023
@reul
Cleanup all transactions at beginning of TransactionsActivityTest.tes…
9d2fcb2 
…tAddMultiCurrencyTransaction().

Some other test sometimes leaves one transaction in the account referred by TRANSACTIONS_ACCOUNT_UID, probably during the cleanup phase.
While this clearing the transactions at the beginning of testAddMultiCurrencyTransaction() might not be the ideal solution, that's the
shortest one I could find that consistently fixes the legacy tests.

I'm convinced this change fixes Issue GnuCash-Pocket#26.
@reul reul mentioned this issue Jun 3, 2023
Merged
@djbrown
Copy link
Author

djbrown commented Jun 6, 2023

fixed by #27

@djbrown djbrown closed this as completed Jun 6, 2023
pnemonic78 pushed a commit to pnemonic78/gnucash-android that referenced this issue Jan 7, 2024
@reul @pnemonic78
Cleanup all transactions at beginning of TransactionsActivityTest.tes…
0bb92af 
…tAddMultiCurrencyTransaction().

Some other test sometimes leaves one transaction in the account referred by TRANSACTIONS_ACCOUNT_UID, probably during the cleanup phase.
While this clearing the transactions at the beginning of testAddMultiCurrencyTransaction() might not be the ideal solution, that's the
shortest one I could find that consistently fixes the legacy tests.

I'm convinced this change fixes Issue GnuCash-Pocket#26.
pnemonic78 pushed a commit to pnemonic78/gnucash-android that referenced this issue Oct 14, 2024
@reul @pnemonic78
Cleanup all transactions at beginning of TransactionsActivityTest.tes…
e10f61a 
…tAddMultiCurrencyTransaction().

Some other test sometimes leaves one transaction in the account referred by TRANSACTIONS_ACCOUNT_UID, probably during the cleanup phase.
While this clearing the transactions at the beginning of testAddMultiCurrencyTransaction() might not be the ideal solution, that's the
shortest one I could find that consistently fixes the legacy tests.

I'm convinced this change fixes Issue GnuCash-Pocket#26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djbrown