Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle fishing events crossing the dateline #23

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Handle fishing events crossing the dateline #23

merged 2 commits into from
Dec 14, 2018

Conversation

pwoods25443
Copy link
Member

@pwoods25443 pwoods25443 commented Dec 14, 2018 •
edited
Loading

Fix #22

Testing

tested with

./scripts/run generate_fishing_events \
  2018-01-01 \
  world-fishing-827.pipe_production_b.messages_scored_   \
  world-fishing-827.pipe_production_b.segment_vessel   \
  world-fishing-827.pipe_production_b.segment_info  \
  world-fishing-827:scratch_paul_ttl_100.fishing_event_12e \
  300

andres-arana
andres-arana approved these changes Dec 14, 2018
View reviewed changes
Copy link
Collaborator

@andres-arana andres-arana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andres-arana andres-arana merged commit 5277f3c into develop Dec 14, 2018
@andres-arana andres-arana deleted the 22-dateline branch December 14, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-arana andres-arana andres-arana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwoods25443 @andres-arana