Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.1 #179

Merged
merged 8 commits into from
Dec 3, 2024
Merged

v2.0.1 #179

merged 8 commits into from
Dec 3, 2024

Conversation

AndreaSanchezTapia
Copy link
Member

Major change - bug fix

  • We updated the parsing of the output of get_vessel_info(). For some advanced
    queries using where, the function was returning only a subset of the vessels.
    This issue is now solved and the number of results should be equal to the number
    of vessels returned by Vessel Viewer on our map. (solves Implement pagination in get_vessel_info() #176)

Breaking changes

  • Some fields in the response were renamed across outputs (addressing issue improve nomenclature consistency #146):

    • get_vessel_info(): in $registryInfo we renamed id to registryId
    • get_event(): we renamed id to eventId and type to eventType

New features

  • get_vessel_info(): We added an index column to indicate which vesselIds
    are grouped together and belong to the same vessel. This should help associate
    information from the returned datasets and guide the user when requesting events
    for a single vessel or a group of vessels.

  • get_event(): We unnested the column-list "vessel" to give more visibility to
    the vessels each event corresponds to.

Minor changes

  • We updated the get_event() section in the README to improve the workflow and
    send groups of vesselIds corresponding to one or multiple vessels.

Copy link
Collaborator

@rociojoo rociojoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch checks OK, installs OK, the readme builds devtools::build_readme(), and the maps page builds pkgdown::build_article(name = "articles/making-maps"). The article lacks alt-text though.

@rociojoo rociojoo merged commit 7c07bb7 into main Dec 3, 2024
@rociojoo rociojoo deleted the fix_vessel_since branch December 3, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants