comparison function sets

GlareDB · Feb 26, 2025 · dc542c3 · dc542c3
1 parent da2d9ff
commit dc542c3
Show file tree

Hide file tree

Showing 3 changed files with 271 additions and 561 deletions.
diff --git a/crates/rayexec_execution/src/expr/comparison_expr.rs b/crates/rayexec_execution/src/expr/comparison_expr.rs
@@ -3,8 +3,14 @@ use std::fmt;
 use super::{AsScalarFunctionSet, Expression};
 use crate::explain::context_display::{ContextDisplay, ContextDisplayMode, ContextDisplayWrapper};
 use crate::functions::function_set::ScalarFunctionSet;
-use crate::functions::scalar::builtin::comparison;
-use crate::functions::scalar::ScalarFunction2;
+use crate::functions::scalar::builtin::comparison::{
+    FUNCTION_SET_EQ,
+    FUNCTION_SET_GT,
+    FUNCTION_SET_GT_EQ,
+    FUNCTION_SET_LT,
+    FUNCTION_SET_LT_EQ,
+    FUNCTION_SET_NEQ,
+};
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
 pub enum ComparisonOperator {
@@ -48,7 +54,16 @@ impl ComparisonOperator {
 
 impl AsScalarFunctionSet for ComparisonOperator {
     fn as_scalar_function_set(&self) -> &ScalarFunctionSet {
-        unimplemented!()
+        match self {
+            ComparisonOperator::Eq => &FUNCTION_SET_EQ,
+            ComparisonOperator::NotEq => &FUNCTION_SET_NEQ,
+            ComparisonOperator::Lt => &FUNCTION_SET_LT,
+            ComparisonOperator::LtEq => &FUNCTION_SET_LT_EQ,
+            ComparisonOperator::Gt => &FUNCTION_SET_GT,
+            ComparisonOperator::GtEq => &FUNCTION_SET_GT_EQ,
+            ComparisonOperator::IsDistinctFrom => unimplemented!(),
+            ComparisonOperator::IsNotDistinctFrom => unimplemented!(),
+        }
     }
 }
 

diff --git a/crates/rayexec_execution/src/functions/scalar/builtin/arith/mul.rs b/crates/rayexec_execution/src/functions/scalar/builtin/arith/mul.rs
@@ -33,7 +33,6 @@ use crate::expr::Expression;
 use crate::functions::function_set::ScalarFunctionSet;
 use crate::functions::scalar::{BindState, RawScalarFunction, ScalarFunction};
 use crate::functions::Signature;
-use crate::logical::binder::table_list::TableList;
 
 pub const FUNCTION_SET_MUL: ScalarFunctionSet = ScalarFunctionSet {
     name: "*",