Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
universalmind303 committed Feb 22, 2024
1 parent a1d14fb commit 7772351
Showing 1 changed file with 3 additions and 28 deletions.
31 changes: 3 additions & 28 deletions datafusion/expr/src/type_coercion/functions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -499,12 +499,15 @@ mod tests {
#[test]
fn test_fixed_list_wildcard_coerce() -> Result<()> {
let inner = Arc::new(Field::new("item", DataType::Int32, false));
let i8_inner = Arc::new(Field::new("item", DataType::Int8, false));
let type_into = DataType::FixedSizeList(inner.clone(), FIXED_SIZE_LIST_WILDCARD);
let cases = vec![
DataType::FixedSizeList(inner.clone(), 2),
DataType::FixedSizeList(inner.clone(), 3),
DataType::FixedSizeList(inner.clone(), FIXED_SIZE_LIST_WILDCARD),
DataType::FixedSizeList(i8_inner.clone(), FIXED_SIZE_LIST_WILDCARD),
DataType::List(inner.clone()),
DataType::LargeList(inner.clone()),
];
for case in cases {
let out = coerced_from(&type_into, &case);
Expand Down Expand Up @@ -534,34 +537,6 @@ mod tests {
let out = coerced_from(&type_into_nested, &type_from_nested);
assert_eq!(out, Some(type_into_nested));

Ok(())
}
#[test]
fn test_fixed_list_no_wildcard_coerce() -> Result<()> {
let inner = Arc::new(Field::new("item", DataType::Int32, false));
let type_into = DataType::FixedSizeList(inner.clone(), 1);
let invalid_cases = vec![
DataType::FixedSizeList(inner.clone(), 2),
DataType::FixedSizeList(inner.clone(), 3),
DataType::FixedSizeList(inner.clone(), 4),
];
for case in invalid_cases {
let out = coerced_from(&type_into, &case);
assert_eq!(out, None);
}

let cases = vec![
DataType::FixedSizeList(inner.clone(), 1),
DataType::FixedSizeList(inner.clone(), FIXED_SIZE_LIST_WILDCARD),
DataType::List(inner.clone()),
];

for case in cases {
let out = coerced_from(&type_into, &case);

assert_eq!(out, Some(type_into.clone()));
}

Ok(())
}
}

0 comments on commit 7772351

Please sign in to comment.