Remove GDAL from Makefile tests #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adebardo
added
the
[POC] Conception To review
|
Good catch! I hadn't noticed GDAL was also in the test section 😅 (As the PR title will become the name of the commit to the main during squash-merge, don't forget to rename it into something easy to grasp like "Remove GDAL from Makefile tests", to facilitate navigation of commits on the main branch! 😉) |
|
Thanks @rhugonnet, is it possible for you to add your review ? |
rhugonnet
approved these changes
Feb 7, 2025
|
Ah yes forgot to approve, sorry, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We realized that we forgot to remove the test for the GDAL installation in the Makefile during our last PR.
This one fixes that oversight.