Merge pull request #1150 from Giveth/get_giv_price_from_givback_calcu…

…lation_instead_of_monoswap Get giv price from givback-calculation instead of monoswap
Giveth · Oct 8, 2023 · ea97ab5 · ea97ab5
2 parents 7edd1f4 + be80bd7
commit ea97ab5
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 18 deletions.
diff --git a/config/test.env b/config/test.env
@@ -68,6 +68,7 @@ REDIS_PORT=6379
 REDIS_PASSWORD=
 
 GIVETH_TRACE_BASE_URL=https://feathers.develop.giveth.io
+GIVETH_GIV_PRICES_URL=https://givback.develop.giveth.io/givPrice
 
 PINATA_GATEWAY_ADDRESS=https://giveth.mypinata.cloud
 

diff --git a/src/resolvers/donationResolver.test.ts b/src/resolvers/donationResolver.test.ts
@@ -1745,7 +1745,7 @@ function createDonationTestCases() {
     assert.isTrue(donation?.isTokenEligibleForGivback);
   });
 
-  it('should fill usd value of when creating donation', async () => {
+  it('should fill usd value of when creating GIV donation', async () => {
     const project = await saveProjectDirectlyToDb(createProjectData());
     const user = await User.create({
       walletAddress: generateRandomEtheriumAddress(),

diff --git a/src/services/donationService.ts b/src/services/donationService.ts
@@ -12,7 +12,7 @@ import {
 import { getTransactionInfoFromNetwork } from './transactionService';
 import { findProjectById } from '../repositories/projectRepository';
 import { convertExponentialNumber } from '../utils/utils';
-import { fetchGivHistoricPrice } from './givPriceService';
+import { fetchGivHistoricPrice, fetchGivPrice } from './givPriceService';
 import {
   findDonationById,
   findStableCoinDonationsWithoutPrice,
@@ -41,18 +41,28 @@ export const updateDonationPricesAndValues = async (
   amount: string | number,
 ) => {
   try {
-    const tokenPrices = await getMonoSwapTokenPrices(
-      currency,
-      baseTokens,
-      Number(priceChainId),
-    );
+    if (currency === 'GIV') {
+      const { givPriceInEth, ethPriceInUsd, givPriceInUsd } =
+        await fetchGivPrice();
+
+      donation.priceEth = toFixNumber(ethPriceInUsd, 7);
+      donation.priceUsd = toFixNumber(givPriceInUsd, 4);
+      donation.valueUsd = toFixNumber(donation.amount * givPriceInUsd, 4);
+      donation.valueEth = toFixNumber(donation.amount * givPriceInEth, 7);
+    } else {
+      const tokenPrices = await getMonoSwapTokenPrices(
+        currency,
+        baseTokens,
+        Number(priceChainId),
+      );
 
-    if (tokenPrices.length !== 0) {
-      donation.priceUsd = Number(tokenPrices[0]);
-      donation.priceEth = Number(tokenPrices[1]);
+      if (tokenPrices.length !== 0) {
+        donation.priceUsd = Number(tokenPrices[0]);
+        donation.priceEth = Number(tokenPrices[1]);
 
-      donation.valueUsd = Number(amount) * donation.priceUsd;
-      donation.valueEth = Number(amount) * donation.priceEth;
+        donation.valueUsd = Number(amount) * donation.priceUsd;
+        donation.valueEth = Number(amount) * donation.priceEth;
+      }
     }
   } catch (e) {
     logger.error('Error in getting price from monoswap', {
@@ -233,18 +243,18 @@ export const updateOldGivDonationsPrice = async () => {
         ...givHistoricPrices,
         valueEth: toFixNumber(
           donation.amount * givHistoricPrices.givPriceInEth,
-          6,
+          7,
         ),
       });
-      donation.priceEth = toFixNumber(givHistoricPrices.ethPriceInUsd, 6);
-      donation.priceUsd = toFixNumber(givHistoricPrices.givPriceInUsd, 3);
+      donation.priceEth = toFixNumber(givHistoricPrices.ethPriceInUsd, 7);
+      donation.priceUsd = toFixNumber(givHistoricPrices.givPriceInUsd, 4);
       donation.valueUsd = toFixNumber(
         donation.amount * givHistoricPrices.givPriceInUsd,
-        3,
+        4,
       );
       donation.valueEth = toFixNumber(
         donation.amount * givHistoricPrices.givPriceInEth,
-        6,
+        7,
       );
       await donation.save();
       await updateTotalDonationsOfProject(donation.projectId);

diff --git a/src/services/givPriceService.ts b/src/services/givPriceService.ts
@@ -1,6 +1,5 @@
 import Axios, { AxiosResponse } from 'axios';
 import axiosRetry from 'axios-retry';
-import config from '../config';
 import { logger } from '../utils/logger';
 import { NETWORK_IDS } from '../provider';
 
@@ -51,3 +50,19 @@ export const fetchGivHistoricPrice = async (
     throw e;
   }
 };
+
+export const fetchGivPrice = async (): Promise<GivPricesResponse> => {
+  try {
+    /**
+     * @see {@link https://givback.develop.giveth.io/api-docs/#/default/get_givPrice}
+     */
+    const result = await Axios.get(givPricesUrl, {
+      headers: { accept: 'application/json' },
+      timeout: axiosTimeout,
+    });
+    return result.data;
+  } catch (e) {
+    logger.error('fetching Giv Price fetchGivPrice() err', e);
+    throw e;
+  }
+};