Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Flip" GIVbacks - most GIVbacks should go out on Optimism, only gnosis donations get GIV on gnosis #4181

Closed
laurenluz opened this issue May 20, 2024 · 11 comments
Assignees
Labels
Dev Research P1 it's a blocker to other tasks or issues.

Comments

@laurenluz
Copy link
Member

As discussed in the last GIVeconomy call, we want to move GIVbacks more onto Optimism network.

So that only donations from gnosis get GIVbacks on Gnosis.
And donations on all other eligible chains, get GIVbacks on Optimism.

cc @WhyldWanderer @divine-comedian @GriffGreen @jainkrati

@laurenluz laurenluz added the P1 it's a blocker to other tasks or issues. label May 20, 2024
@WhyldWanderer
Copy link

Thanks for making the issue Lauren.

I want to emphasize the importance of not springing this on donors in the middle of a round.
We should announce it before we start and have it start at the beginning of a round rather than in the middle.

I plan to put information about it in the upcoming GIVbacks forum posts so that people are aware that we are working on changing how it works..

@laurenluz
Copy link
Member Author

@mohammadranjbarz do you think we'll be able to deliver this by the start of the next round Tuesday May 28?

@mohammadranjbarz
Copy link
Contributor

@mohammadranjbarz do you think we'll be able to deliver this by the start of the next round Tuesday May 28?

@laurenluz Yeah I try to do it, but we should hold on and don't merge till @WhyldWanderer give us approval to merge it

@mohammadranjbarz
Copy link
Contributor

It's implemented on #4181 (comment), but we just can merge it after @WhyldWanderer tell us

FYI @divine-comedian @laurenluz

@jainkrati
Copy link
Collaborator

lets merge and close this @mohammadranjbarz

@mohammadranjbarz
Copy link
Contributor

lets merge and close this @mohammadranjbarz

ّI think we should wait till @WhyldWanderer tell us merge it, because Ashley wants to have this feature after distributing previous givback rewards

@WhyldWanderer
Copy link

Yes please!
I will let you know when we have the green light to merge it.

We still have a couple rounds to distribute first.
Thanks Krati & Mohammad!

@jainkrati
Copy link
Collaborator

let us know when we should proceed @WhyldWanderer

@WhyldWanderer
Copy link

This is now ready for implementation @mohammadranjbarz @jainkrati

@mohammadranjbarz
Copy link
Contributor

This is now ready for implementation @mohammadranjbarz @jainkrati

Thanks @WhyldWanderer I merged/deployed it, please let me know if you found something incorrect

@divine-comedian divine-comedian moved this from Dev Research to Done in All-Devs Jul 8, 2024
@WhyldWanderer
Copy link

I finished the calculation today and everything looks accurate!

Great job guys <3

I think we can close this one now

@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Research P1 it's a blocker to other tasks or issues.
Projects
Status: Merged to Production
Development

No branches or pull requests

5 participants