-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIVpower Boosting | Handling GIVpoewr for canceled projects #1837
Comments
cc @aminlatifi |
…ect detail edit related to Giveth/giveth-dapps-v2#1837
@maryjaf please test :) |
When the canceled project becomes active again,what is the expectation? |
Now when we cancel a project we remove all boostings of that project and change the other project's percentages for users who boosted the project, but we don't change the snapshot data , so when we activate it again the ranking would appear because in current round it had some snapshots, but for next rounds it would not have any rank, I talked 2ith @aminlatifi and he thinks it's ok but @laurenluz you tell me what should we do. |
Hey @mohammadranjbarz ! I think that is ok. It's a super rare case, as you said. I like removing all the boostings and changing the other project's percentages, and think it is ok that we don't change the snapshot data. Once this is built, let's move it to get tested :) |
I tested this, and after canceling the project, the boosts of this project are properly eliminated and assigned to other user's projects. |
@mohammadranjbarz Can you have a look?
Check to see what is happening with GIVpoewr when a project is cancelled. We are thinking it would be good - if a project becomes cancelled - then we make GIVpower on it all set to zero... so each user's GIVpower gets proportionally added to their other project.
let me know if you have any questions.
The text was updated successfully, but these errors were encountered: