Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIVpower Boosting | Handling GIVpoewr for canceled projects #1837

Closed
laurenluz opened this issue Nov 16, 2022 · 7 comments
Closed

GIVpower Boosting | Handling GIVpoewr for canceled projects #1837

laurenluz opened this issue Nov 16, 2022 · 7 comments
Assignees
Labels
GIVeconomy GIVPower GIVpower Test Env

Comments

@laurenluz
Copy link
Member

@mohammadranjbarz Can you have a look?

Check to see what is happening with GIVpoewr when a project is cancelled. We are thinking it would be good - if a project becomes cancelled - then we make GIVpower on it all set to zero... so each user's GIVpower gets proportionally added to their other project.

let me know if you have any questions.

@laurenluz
Copy link
Member Author

cc @aminlatifi

@mohammadranjbarz
Copy link
Contributor

@maryjaf @MoeNick
It's on staging, you can test it now

@laurenluz
Copy link
Member Author

@maryjaf please test :)

@maryjaf
Copy link
Collaborator

maryjaf commented Nov 23, 2022

When the canceled project becomes active again,what is the expectation?
Now it is the case that the project's rank returns to the previous rank, but the project hasn't any boost
I think the projected and current rank changed to "--" because it hasn't any boost
@mohammadranjbarz @laurenluz
image.png

@maryjaf maryjaf closed this as completed Nov 23, 2022
@maryjaf maryjaf reopened this Nov 23, 2022
@Giveth Giveth deleted a comment from maryjaf Nov 24, 2022
@mohammadranjbarz
Copy link
Contributor

@maryjaf

Now when we cancel a project we remove all boostings of that project and change the other project's percentages for users who boosted the project, but we don't change the snapshot data , so when we activate it again the ranking would appear because in current round it had some snapshots, but for next rounds it would not have any rank, I talked 2ith @aminlatifi and he thinks it's ok but @laurenluz you tell me what should we do.
I think it's really a rare case that we cancel a project and activate it in the same round so we can skip this.
please tell me the decision I would it

@laurenluz
Copy link
Member Author

Hey @mohammadranjbarz ! I think that is ok. It's a super rare case, as you said. I like removing all the boostings and changing the other project's percentages, and think it is ok that we don't change the snapshot data.

Once this is built, let's move it to get tested :)

@maryjaf
Copy link
Collaborator

maryjaf commented Nov 25, 2022

I tested this, and after canceling the project, the boosts of this project are properly eliminated and assigned to other user's projects.
The only problem with the reactivation I raised above is and is accepted according to the conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GIVeconomy GIVPower GIVpower Test Env
Projects
None yet
Development

No branches or pull requests

3 participants