Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #28

Merged
merged 4 commits into from
Oct 3, 2021
Merged

Unit tests #28

merged 4 commits into from
Oct 3, 2021

Conversation

nolancon
Copy link
Contributor

@nolancon nolancon commented Oct 2, 2021

Some more basic unit tests to help out with #6

Gituser143
Gituser143 approved these changes Oct 3, 2021
View reviewed changes
Copy link
Owner

@Gituser143 Gituser143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Unless you'd like to add more tests, I'll merge this PR.

@nolancon
Copy link
Contributor Author

nolancon commented Oct 3, 2021

Cool. You can merge this as is, thanks.

@Gituser143 Gituser143 merged commit 932c593 into Gituser143:test Oct 3, 2021
@Gituser143
Copy link
Owner

@nolancon thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gituser143 Gituser143 Gituser143 approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolancon @Gituser143