Feature/3101 rename config to configuration

[HHobeck]

• Rename the class Config to Configuration. Change namespace Configuration to Configurations.
• Rename the class BranchConfig to BranchConfiguration. Change parameter name config to configuration..

Description

This is a refactoring step without any business logic change.

Related Issue

no related issue.

Motivation and Context

Refactoring of Configuration to have clear naming.

How Has This Been Tested?

All unit and integration tests have been executed.

Screenshots (if appropriate):

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[asbjornu]

This is great, but please let's discuss changes like this in an issue before you invest time in a PR. I think the namespace should remain GitVersion.Configuration and the Config class can be renamed to GitVersionConfiguration. Thoughts @HHobeck @arturcic?

[arturcic]

GitVersionConfiguration

Agree with that

[HHobeck]

This is great, but please let's discuss changes like this in an issue before you invest time in a PR. I think the namespace should remain GitVersion.Configuration and the Config class can be renamed to GitVersionConfiguration. Thoughts @HHobeck @arturcic?

Okay no problem. I can change it back. I did the namespace change because otherwise the namespace conflicts with the class name. Actually I think we are in the domain of GitVersion to name the class GitVersionConfiguration or GitVersionContext seem for me technically motivated. What about OverallConfiguration!? ;)

[asbjornu]

I think we are in the domain of GitVersion to name the class GitVersionConfiguration or GitVersionContext seem for me technically motivated.

As the configuration file is named GitVersion.yml, I think the name GitVersionConfiguration is quite fitting.

What about OverallConfiguration!? ;)

Not a fan, sorry.

[arturcic]

@HHobeck I think we need to rename more classes that contain the prefix or suffix Config for example in the folder https://github.com/GitTools/GitVersion/tree/746efd9290c5ca5fc0164ceecc3b4668adda9c68/src/GitVersion.Core/Configuration, or some of the Unit test class names, do you agree?

[asbjornu]

Awesome! 👏🏼

[arturcic]

There are a couple of other classes to be renamed:
OverrideConfigOptionParser
ConfigExtensionsTests
ConfigProviderTests
DefaultConfigFileLocatorTests
IgnoreConfigTests

[asbjornu]

Looking good! 👍🏼

[HHobeck]

Okay I'm done please take a look and give me feedback. I would prefer to hold on and not to refactor anything else in the PR.

[HHobeck]

Please also notice the implementation of ScratchConfigurationBuilder (I'm not sure if EmptyConfigurationBuilder is maybe better!?) and GitFlowConfigurationBuilder. In my opinion this should be used for unit and integration tests.

[arturcic]

@asbjornu when you're done with the review please merge this one

[asbjornu]

Marvellous work @HHobeck! 👏🏼

[mergify]

Thank you @HHobeck for your contribution!

[arturcic]

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀