Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "CategoricalArrays" to "0.9" #1493

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2020

This pull request changes the compat entry for the CategoricalArrays package from 0.8 to 0.8, 0.9.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-io
Copy link

codecov-io commented Nov 8, 2020

Codecov Report

Merging #1493 (7fbebfb) into master (e992927) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1493   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files          39       39           
  Lines        4395     4395           
=======================================
  Hits         3909     3909           
  Misses        486      486           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e992927...7fbebfb. Read the comment docs.

@bjarthur bjarthur merged commit ebe9626 into master Nov 10, 2020
@bjarthur bjarthur deleted the compathelper/new_version/2020-11-08-00-43-42-025-4168538699 branch November 10, 2020 12:19
@nalimilan
Copy link
Contributor

Note that CI didn't actually use CategoricalArrays 0.9 since DataFrames 0.21 (which is required by Gadfly) only supported version 0.8. See #1499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants