Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag Scale.color_none for deprecation #1469

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Aug 9, 2020

  • I've updated the documentation to reflect these changes
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Scale.color_none was not the right design, see #527 (comment). This PR flags Scale.color_none for deprecation, in favour of e.g. plot(..., Geom.contour, color=[colorant"black"]).

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2020

Codecov Report

Merging #1469 into master will decrease coverage by 0.15%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   89.32%   89.17%   -0.16%     
==========================================
  Files          39       39              
  Lines        4395     4398       +3     
==========================================
- Hits         3926     3922       -4     
- Misses        469      476       +7     
Impacted Files Coverage Δ
src/scale.jl 94.84% <0.00%> (-2.75%) ⬇️
src/Gadfly.jl 75.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d507b20...9c52e15. Read the comment docs.

@Mattriks Mattriks merged commit 2b240fd into GiovineItalia:master Aug 11, 2020
dehann added a commit to dehann/Gadfly.jl that referenced this pull request Aug 13, 2020
flag Scale.color_none for deprecation (GiovineItalia#1469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contour plot with all lines in one color
2 participants