Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for using PackageCompiler.jl #1467

Merged
merged 3 commits into from
Aug 1, 2020

Conversation

f-ttok
Copy link
Contributor

@f-ttok f-ttok commented Jul 28, 2020

I found that PackageCompiler.jl had been updated and procedures to compile packages had been changed.
This PR gives some modifications to instructions to compile Gadfly.jl in the document.

In my environment, PackageCompiler.jl added by ]add PackageCompiler (not ]dev PackageCompiler ) works well, so I think the first caveat may not be necessary.

PackageCompiler is a work in progress, and the most recent tagged release
sometimes (currently as of this writing) does not work. Hence the dev
instead of add command to install.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #1467 into master will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   90.23%   89.44%   -0.79%     
==========================================
  Files          39       39              
  Lines        4197     4416     +219     
==========================================
+ Hits         3787     3950     +163     
- Misses        410      466      +56     
Impacted Files Coverage Δ
src/poetry.jl 90.74% <0.00%> (-5.26%) ⬇️
src/theme.jl 65.07% <0.00%> (-4.42%) ⬇️
src/geom/label.jl 96.26% <0.00%> (-2.74%) ⬇️
src/geom/beeswarm.jl 90.00% <0.00%> (-2.65%) ⬇️
src/aesthetics.jl 77.77% <0.00%> (-2.06%) ⬇️
src/misc.jl 65.06% <0.00%> (-2.06%) ⬇️
src/Gadfly.jl 75.88% <0.00%> (-1.92%) ⬇️
src/color_misc.jl 60.60% <0.00%> (-1.47%) ⬇️
src/geom/rectbin.jl 80.00% <0.00%> (-1.09%) ⬇️
src/guide/keys.jl 82.69% <0.00%> (-0.97%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f759d9c...bb10fde. Read the comment docs.

@Mattriks Mattriks requested a review from bjarthur July 31, 2020 13:16
@bjarthur
Copy link
Member

bjarthur commented Aug 1, 2020

thanks! looks great.

@bjarthur bjarthur merged commit 81783d5 into GiovineItalia:master Aug 1, 2020
@f-ttok f-ttok deleted the docs-compilation branch August 2, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants