Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for CategoricalArrays to 0.8 #1447

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented May 31, 2020

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

  • bumps compat for CategoricalArrays to 0.8
  • and DataFrames to 0.21

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #1447 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage   89.38%   89.40%   +0.02%     
==========================================
  Files          39       39              
  Lines        4379     4379              
==========================================
+ Hits         3914     3915       +1     
+ Misses        465      464       -1     
Impacted Files Coverage Δ
src/dataframes.jl 97.56% <100.00%> (ø)
src/misc.jl 65.06% <100.00%> (ø)
src/mapping.jl 85.84% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8cb45...300228b. Read the comment docs.

@Mattriks
Copy link
Member Author

Once this is merged, we should do a new release in about a week or so.

@Mattriks Mattriks merged commit 19704bd into GiovineItalia:master Jun 1, 2020
@bjarthur
Copy link
Member

bjarthur commented Jun 2, 2020

or... wouldn't it have been better to tag a release before this was merged so that people who do not want to upgrade CategoricalArrays and DataFrames can get the latest Gadfly features and bug fixes. is it possible to tag a release of a commit that is not master?

@Mattriks
Copy link
Member Author

Mattriks commented Jun 2, 2020

The compats have to be bumped sometime! My thoughts were that the imminent minor release (1.3) should include this compat bump to CategoricalArrays 0.8. Also the next minor release (1.4) will probably include DataFrames 1.0.

@bjarthur
Copy link
Member

bjarthur commented Jun 2, 2020

could have had it both ways by tagging 1.3 before this merge, and then 1.3.1 immediately after. dependency compatibility is a huge pain sometimes so it's important to give people both options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants