Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme grid order and panel line width #1408

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Mar 28, 2020

  • I've updated the documentation to reflect these changes
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

Example:

In this example, the grid lines are behind the panel frame.

plot(x=[5100, 5400], y=[0, 1], Geom.blank,
    Guide.yticks(ticks=0:0.1:1),
    Theme(grid_line_style=:solid, grid_line_width=0.5mm,
        grid_color="gray92", panel_stroke="black", 
        grid_line_order=-2,  panel_line_width=1mm)
)

gridstyle

@Mattriks Mattriks mentioned this pull request Mar 29, 2020
6 tasks
@Mattriks Mattriks closed this Apr 3, 2020
@Mattriks Mattriks reopened this Apr 3, 2020
@Mattriks
Copy link
Member Author

Mattriks commented Apr 3, 2020

Tests are passing now with RDatasets 0.6.7. For this PR, I just need to check off the regression tests.

@Mattriks
Copy link
Member Author

Mattriks commented Apr 3, 2020

The regression test pass. The only other testscript to use panel_stroke is "subplot_layers.jl". For "subplot_layers.jl" there is a difference in the panel border (slightly thinner for devel-output compared to master-output - for master the panel border must be inheriting it's linewidth from somewhere, because it's not explicitly set). But I've tested this PR with Geom.subplot_grid, and the new features panel_line_width and grid_line_order behave as expected. So this PR is ready to merge.

@Mattriks
Copy link
Member Author

Mattriks commented Apr 6, 2020

bump @bjarthur

@bjarthur bjarthur merged commit 32022d0 into GiovineItalia:master Apr 7, 2020
@Mattriks Mattriks deleted the grid_and_panel branch April 17, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible improvements for panel border
2 participants