remove test dependency on CSV #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 37 37
Lines 3945 3945
=======================================
Hits 3575 3575
Misses 370 370Continue to review full report at Codecov.
|
Mattriks
reviewed
Nov 17, 2019
| @@ -1,5 +1,7 @@ | |||
| using Gadfly, DataFrames, Compat, CSV | |||
| using Gadfly, DataFrames, Compat, DelimitedFiles | |||
Mattriks
reviewed
Nov 17, 2019
test/testscripts/issue120.jl
Outdated
|
|
||
| set_default_plot_size(6inch, 3inch) | ||
|
|
||
| plot(CSV.read(joinpath(dirname(@__DIR__), "data","issue120.csv")), x=:x1, y=:x2) | ||
| dlm = readdlm(joinpath(dirname(@__DIR__), "data","issue120.csv"), ',') |
There was a problem hiding this comment.
or in this style (using header=true)
dlm, varnames = readdlm( joinpath(...), ',', header=true)which will simplify the next line (no convert needed for my dlm)
|
i'm working on a second PR which removes all Compat. no longer necessary now that we don't support 0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only one test used it, so i refactored to use DelimitedFiles in the standard library instead.