Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Showoff 0.3 #1298

Merged
merged 1 commit into from
Jul 15, 2019
Merged

add Showoff 0.3 #1298

merged 1 commit into from
Jul 15, 2019

Conversation

bjarthur
Copy link
Member

the docs failed to build on #1295 because Showoff has been updated.

  • [x ] I've run the regression tests

@codecov-io
Copy link

Codecov Report

Merging #1298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1298   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          36       36           
  Lines        3959     3959           
=======================================
  Hits         3568     3568           
  Misses        391      391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019ef9e...734c03a. Read the comment docs.

@bjarthur bjarthur merged commit ad10e7b into GiovineItalia:master Jul 15, 2019
@bjarthur
Copy link
Member Author

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

@bjarthur bjarthur deleted the bja/showoff branch July 16, 2019 00:08
@@ -47,7 +47,7 @@ Juno = "0.7"
KernelDensity = "0.5"
Loess = "0.4, 0.5"
Measures = "0.3"
Showoff = "0.2"
Showoff = "0.2, 0.3"
julia = "0.7, 1"
CSV = "0.4, 0.5"
Cairo = "0.5, 0.6"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@Mattriks
Copy link
Member

Mattriks commented Jul 17, 2019

There's a few figures missing from the docs (both v1.1 and dev). E.g.
Geom.bar, Geom.contour (2nd figure), Geom.ellipse etc. All these plots use RDatasets, but there are also other plots that use RDatasets and display properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants