Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testscript date_bar.jl deterministic wrt date run #1279

Merged
merged 1 commit into from
Apr 21, 2019

Conversation

non-Jedi
Copy link
Contributor

Non-deterministic testscript discovered while regression testing #1276.

Contributor checklist:

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've squash'ed or fixup'ed junk commits with git-rebase
  • I've built the docs and confirmed these changes don't cause new errors

@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #1279 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   90.33%   90.08%   -0.26%     
==========================================
  Files          36       36              
  Lines        3943     3954      +11     
==========================================
  Hits         3562     3562              
- Misses        381      392      +11
Impacted Files Coverage Δ
src/aesthetics.jl 80.17% <0%> (-2.13%) ⬇️
src/scale.jl 97.41% <0%> (-1.28%) ⬇️
src/theme.jl 71.18% <0%> (-1.23%) ⬇️
src/mapping.jl 84.61% <0%> (-0.83%) ⬇️
src/misc.jl 65.77% <0%> (-0.45%) ⬇️
src/Gadfly.jl 78.58% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df68de...2a42c08. Read the comment docs.

@bjarthur bjarthur merged commit 4d50fb4 into GiovineItalia:master Apr 21, 2019
@bjarthur
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants