Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put only a single copy of gadfly.js and snap.svg-min.js in text/html output #1259

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

bjarthur
Copy link
Member

title says it all. a copy is already put in by the preceding call to SVGJS.

@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #1259 into master will increase coverage by 4.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   85.34%   90.33%   +4.99%     
==========================================
  Files          36       36              
  Lines        4148     3943     -205     
==========================================
+ Hits         3540     3562      +22     
+ Misses        608      381     -227
Impacted Files Coverage Δ
src/Gadfly.jl 78.98% <ø> (+4.46%) ⬆️
src/geom/bar.jl 93.23% <0%> (+1.38%) ⬆️
src/shapes.jl 100% <0%> (+1.96%) ⬆️
src/geom/polygon.jl 94.87% <0%> (+2.37%) ⬆️
src/mapping.jl 85.43% <0%> (+2.41%) ⬆️
src/geom/segment.jl 94.44% <0%> (+2.55%) ⬆️
src/guide.jl 87.87% <0%> (+3.48%) ⬆️
src/guide/keys.jl 94.73% <0%> (+3.59%) ⬆️
src/coord.jl 88.17% <0%> (+3.63%) ⬆️
src/color_misc.jl 62.06% <0%> (+4%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbd6d4...047fdab. Read the comment docs.

@bjarthur bjarthur merged commit 9df68de into GiovineItalia:master Mar 12, 2019
@bjarthur bjarthur deleted the bja/extrajavascript branch March 12, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants