Tweak mapping to improve plotting performance #1229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a learning exercise for me to practice using Julia profiling tools. I picked Gadfly's plot function as it seemed likely to have some low hanging fruit while being relatively simple to grok. These changes improve the benchmark posted below on my system from 18.7 microseconds to 10.3 microseconds through minor refactoring; definitely not earth-shattering but in the direction of goodness. I leave it to the maintainers discretion whether it's worth their time to review this patch.
Note that this only improves plot generation and not plot display, which takes the bulk of the time in an interactive plotting session.
Contributor checklist:
NEWS.md
squash
'ed orfixup
'ed junk commits with git-rebase