Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cairo.jl compatibility #366

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Conversation

CiaranOMara
Copy link
Contributor

This pull request is in response to GiovineItalia/Gadfly.jl#1339 (comment).

I did not get a diff between the test output with Cairo.jl compatibility set to v0.7 and with Cairo.jl compatibility explicitly set to v0.8.

@CiaranOMara CiaranOMara changed the title Set Cario.jl compatibility to [0.70, 1.0.0) Set Cairo.jl compatibility to [0.70, 1.0.0) Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files          18       18           
  Lines        3057     3057           
=======================================
  Hits         1247     1247           
  Misses       1810     1810

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be908fd...93b7e73. Read the comment docs.

@CiaranOMara
Copy link
Contributor Author

The documentation built from this commit also looks good to me.

@CiaranOMara CiaranOMara changed the title Set Cairo.jl compatibility to [0.70, 1.0.0) Set Cairo.jl compatibility Nov 9, 2019
@bjarthur bjarthur merged commit 3c4a82e into GiovineItalia:master Nov 9, 2019
@bjarthur
Copy link
Member

bjarthur commented Nov 9, 2019

thanks for this!

@CiaranOMara CiaranOMara deleted the feature/cairo branch November 9, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants