Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Refs rather than globals for atsign-requires dependencies #342

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Jan 31, 2019

This appears to fix problems involving Compose, Cairo, and Fontconfig. The idea is to avoid using variables that get defined only via global statements that run only in @require blocks, and switch to a strategy to uses variables that are defined at precompilation time. Here I do that by defining the variables as Refs, so I can update their contents when they get initialized.

Fixes GiovineItalia/Gadfly.jl#1206
Replaces #341

This is not based on deep knowledge of what packages are or are not needed for my plotting task. I was simply following https://github.com/JuliaGraphs/GraphPlot.jl and then responded to messages about needing to import Cairo, Fontconfig.

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #342 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   38.05%   38.09%   +0.03%     
==========================================
  Files          18       18              
  Lines        3127     3124       -3     
==========================================
  Hits         1190     1190              
+ Misses       1937     1934       -3
Impacted Files Coverage Δ
src/pango.jl 0% <0%> (ø) ⬆️
src/Compose.jl 20.23% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b8758...8ecff93. Read the comment docs.

@bjarthur bjarthur merged commit 14bc78f into master Feb 1, 2019
@bjarthur bjarthur deleted the teh/fix_pango branch February 1, 2019 17:50
@bjarthur
Copy link
Member

bjarthur commented Feb 1, 2019

thanks tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: LoadError: UndefVarError: pangolayout not defined
3 participants