Skip to content

Commit

Permalink
Fix failing specs
Browse files Browse the repository at this point in the history
  • Loading branch information
@GilbertCherrie
GilbertCherrie committed Dec 7, 2023
1 parent f1dc270 commit 64e21b6
Show file tree
Hide file tree
Showing 15 changed files with 62 additions and 94 deletions.
4 changes: 0 additions & 4 deletions ...dd-remove-security-groups-form/__snapshots__/add-remove-security-groups-form.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ exports[`Add/remove security groups form component should add security group 1`]
>
<div
aria-atomic="true"
aria-labelledby="loading-id-3"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down Expand Up @@ -100,7 +99,6 @@ exports[`Add/remove security groups form component should remove security group
>
<div
aria-atomic="true"
aria-labelledby="loading-id-4"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down Expand Up @@ -168,7 +166,6 @@ exports[`Add/remove security groups form component should render add security gr
>
<div
aria-atomic="true"
aria-labelledby="loading-id-1"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down Expand Up @@ -236,7 +233,6 @@ exports[`Add/remove security groups form component should render remove security
>
<div
aria-atomic="true"
aria-labelledby="loading-id-2"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down
3 changes: 0 additions & 3 deletions ...cript/spec/ansible-edit-catalog-form/__snapshots__/ansible-edit-catalog-form.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27155,7 +27155,6 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie
data-invalid={null}
>
<textarea
aria-describedby={null}
aria-invalid={null}
className="bx--text-area"
cols={50}
Expand Down Expand Up @@ -85528,7 +85527,6 @@ exports[`Ansible playbook edit catalog Form Component should render correct form
data-invalid={null}
>
<textarea
aria-describedby={null}
aria-invalid={null}
className="bx--text-area"
cols={50}
Expand Down Expand Up @@ -146799,7 +146797,6 @@ exports[`Ansible playbook edit catalog Form Component should render retirement p
data-invalid={null}
>
<textarea
aria-describedby={null}
aria-invalid={null}
className="bx--text-area"
cols={50}
Expand Down
2 changes: 0 additions & 2 deletions app/javascript/spec/button-group/__snapshots__/button-group-form.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ exports[`Button Group form component should render the editing form 1`] = `
>
<div
aria-atomic="true"
aria-labelledby="loading-id-1"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down Expand Up @@ -127,7 +126,6 @@ exports[`Button Group form component should render the editing form for generic
>
<div
aria-atomic="true"
aria-labelledby="loading-id-2"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down
2 changes: 0 additions & 2 deletions app/javascript/spec/custom-buttom-form/__snapshots__/custom-button-form.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ exports[`Custom Button form component should edit a generic object custom button
>
<div
aria-atomic="true"
aria-labelledby="loading-id-4"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down Expand Up @@ -884,7 +883,6 @@ exports[`Custom Button form component should render the editing form for generic
>
<div
aria-atomic="true"
aria-labelledby="loading-id-1"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down
12 changes: 4 additions & 8 deletions app/javascript/spec/generic-objects-form/__snapshots__/generic-objects-form.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9244,8 +9244,7 @@ exports[`Generic Object Form Component should render editing a generic object wi
aria-label="Clear selected item"
className="bx--list-box__selection"
onClick={[Function]}
onKeyDown={[Function]}
tabIndex={0}
tabIndex={-1}
title="Clear selected item"
type="button"
>
Expand Down Expand Up @@ -9912,8 +9911,7 @@ exports[`Generic Object Form Component should render editing a generic object wi
aria-label="Clear selected item"
className="bx--list-box__selection"
onClick={[Function]}
onKeyDown={[Function]}
tabIndex={0}
tabIndex={-1}
title="Clear selected item"
type="button"
>
Expand Down Expand Up @@ -16873,8 +16871,7 @@ exports[`Generic Object Form Component should render editing a generic object wi
aria-label="Clear selected item"
className="bx--list-box__selection"
onClick={[Function]}
onKeyDown={[Function]}
tabIndex={0}
tabIndex={-1}
title="Clear selected item"
type="button"
>
Expand Down Expand Up @@ -17541,8 +17538,7 @@ exports[`Generic Object Form Component should render editing a generic object wi
aria-label="Clear selected item"
className="bx--list-box__selection"
onClick={[Function]}
onKeyDown={[Function]}
tabIndex={0}
tabIndex={-1}
title="Clear selected item"
type="button"
>
Expand Down
34 changes: 18 additions & 16 deletions app/javascript/spec/notification-drawer/__snapshots__/notification-drawer.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003625"
light={false}
menuOffset={[Function]}
Expand Down Expand Up @@ -393,7 +393,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003625"
light={false}
menuOffset={[Function]}
Expand Down Expand Up @@ -530,7 +530,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003625"
light={false}
menuOffset={[Function]}
Expand Down Expand Up @@ -624,7 +624,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003625"
light={false}
menuOffset={[Function]}
Expand All @@ -647,6 +647,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
onClickOutside={[Function]}
>
<button
aria-controls={null}
aria-expanded={false}
aria-haspopup={true}
aria-label="open and close options"
Expand All @@ -661,11 +662,11 @@ exports[`Notification drawer tests should render correctly 1`] = `
type="button"
>
<ForwardRef(OverflowMenuVertical16)
aria-label="open and close list of options"
aria-label="Open and close list of options"
className="bx--overflow-menu__icon"
>
<Icon
aria-label="open and close list of options"
aria-label="Open and close list of options"
className="bx--overflow-menu__icon"
fill="currentColor"
height={16}
Expand All @@ -675,7 +676,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
xmlns="http://www.w3.org/2000/svg"
>
<svg
aria-label="open and close list of options"
aria-label="Open and close list of options"
className="bx--overflow-menu__icon"
fill="currentColor"
focusable="false"
Expand All @@ -702,7 +703,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
r="2"
/>
<title>
open and close list of options
Open and close list of options
</title>
</svg>
</Icon>
Expand Down Expand Up @@ -753,7 +754,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003624"
light={false}
menuOffset={[Function]}
Expand Down Expand Up @@ -847,7 +848,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003624"
light={false}
menuOffset={[Function]}
Expand Down Expand Up @@ -985,7 +986,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003624"
light={false}
menuOffset={[Function]}
Expand Down Expand Up @@ -1079,7 +1080,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
flipped={true}
floatingmenu="true"
focusTrap={true}
iconDescription="open and close list of options"
iconDescription="Open and close list of options"
id="10000000003624"
light={false}
menuOffset={[Function]}
Expand All @@ -1102,6 +1103,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
onClickOutside={[Function]}
>
<button
aria-controls={null}
aria-expanded={false}
aria-haspopup={true}
aria-label="open and close options"
Expand All @@ -1116,11 +1118,11 @@ exports[`Notification drawer tests should render correctly 1`] = `
type="button"
>
<ForwardRef(OverflowMenuVertical16)
aria-label="open and close list of options"
aria-label="Open and close list of options"
className="bx--overflow-menu__icon"
>
<Icon
aria-label="open and close list of options"
aria-label="Open and close list of options"
className="bx--overflow-menu__icon"
fill="currentColor"
height={16}
Expand All @@ -1130,7 +1132,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
xmlns="http://www.w3.org/2000/svg"
>
<svg
aria-label="open and close list of options"
aria-label="Open and close list of options"
className="bx--overflow-menu__icon"
fill="currentColor"
focusable="false"
Expand All @@ -1157,7 +1159,7 @@ exports[`Notification drawer tests should render correctly 1`] = `
r="2"
/>
<title>
open and close list of options
Open and close list of options
</title>
</svg>
</Icon>
Expand Down
2 changes: 0 additions & 2 deletions app/javascript/spec/policy-profile-form/__snapshots__/policy-profile-form.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ exports[`PolicyProfileForm form component should render editing form variant 1`]
>
<div
aria-atomic="true"
aria-labelledby="loading-id-2"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down Expand Up @@ -104,7 +103,6 @@ exports[`PolicyProfileForm form component should render new form variant 1`] = `
>
<div
aria-atomic="true"
aria-labelledby="loading-id-1"
aria-live="assertive"
className="export-spinner bx--loading bx--loading--small"
>
Expand Down
Loading

0 comments on commit 64e21b6

Please sign in to comment.