Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSIO compose #918

Merged
merged 2 commits into from
May 28, 2020
Merged

LSIO compose #918

merged 2 commits into from
May 28, 2020

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented May 27, 2020

Purpose
Use linuxserver/docker-compose to run docker-compose inside a docker container as needed instead of installing it natively using python. This also allows us to remove the use of python across the whole project. Docker officially offers this method, but only with x86_64. We previously attempted to use this method with Docker's official image but needed to support ARM CPU systems and settled on python and later improved python3. LSIO offering compose in a container and including multiarch builds resolves the need. If in the future Docker officially offers multiarch compose images we can easily switch to their official image and script.

Learning
https://github.com/linuxserver/docker-docker-compose
docker/compose#6831

Requirements
Check all boxes as they are completed

@nemchik nemchik changed the title Lsio compose LSIO compose May 27, 2020
@nemchik nemchik merged commit ec32bc3 into master May 28, 2020
@nemchik nemchik deleted the lsio-compose branch May 28, 2020 14:10
@idolize
Copy link
Contributor

idolize commented May 29, 2020

Cool! This only affects new installations of DockSTARTer, right?

@nemchik
Copy link
Member Author

nemchik commented May 29, 2020

It will affect new installs and anyone who updates DS. You can update via the menu (ds) or command ds -u.

The main benefit to existing users is not having the python dependencies. DS isn't uninstalling the python dependencies since other applications might need them, but nothing in DS will be making use of them anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants