Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow case sensetive urls #4

Merged
merged 4 commits into from
Feb 10, 2016
Merged

allow case sensetive urls #4

merged 4 commits into from
Feb 10, 2016

Conversation

mathiasnohall
Copy link
Contributor

Cannot do redirect to case sensetive urls. Since they get tolowered.

i.e. trying to do a redirect from: /downloads
to: /foobar?currentTab=FreeTrials
gets redirected to /foobar?currenttab=freetrials

@evest
Copy link
Contributor

evest commented Jan 27, 2016

Sorry for taking so long, but this one is a bit more complex than I initially thought. If we do not lowercase the old url, any existing redirects will have a case sensitive lookup, which is bound to make a lot of them fail. At least it looks like that when looking at the code.

I can see that the new url could be case sensitive, there is no good reason for making it lowercase (especially including the query string), well - except that urls really should be case insensitive by default :-)

If you could prepare a new PR, keeping the lowercasing of the old url as is, but not lowercasing the new one, make sure you test this with existing urls (with varying casing), I'll merge it in.

@mathiasnohall
Copy link
Contributor Author

Agreed. Only changing the new url is fine for us and the old urls are still lowercased wich prevents old lookups to fail

evest added a commit that referenced this pull request Feb 10, 2016
Allow case sensitive redirect urls
@evest evest merged commit 999ced8 into Geta:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants