fix: add missing dependencies to ChannelList hooks effects #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
oliverlaz,
myandrienko and
arnautov-anton
|
Size Change: -231 B (-0.02%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2525 +/- ##
=======================================
Coverage 86.52% 86.52%
=======================================
Files 392 392
Lines 8185 8185
Branches 1959 1959
=======================================
Hits 7082 7082
Misses 1015 1015
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Sep 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
## [12.2.0](v12.1.0...v12.2.0) (2024-10-07) ### Bug Fixes * add missing dependencies to ChannelList hooks effects ([#2525](#2525)) ([9cb8e47](9cb8e47)) ### Features * add openThread prop to VirtualizedMessageList ([#2523](#2523)) ([e95eaa4](e95eaa4)) ### Refactors * useScrollToBottomOnNewMessage hook ([#2532](#2532)) ([8980016](8980016))
|
🎉 This PR is included in version 12.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
fix #2524 and fix all the ChannelList hook effect deps.