Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgrouting binaries for bionic and documentation #4472

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@submarcos submarcos added the dependencies Pull requests that update a dependency file label Jan 31, 2025
@submarcos submarcos force-pushed the improve_doc_for_pgrouting_upgrade branch from bbe8600 to 9f2ae24 Compare January 31, 2025 14:12
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (8df192f) to head (6130d4f).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4472   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         269      269           
  Lines       21469    21469           
=======================================
  Hits        21140    21140           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 31, 2025

Geotrek-admin    Run #10899

Run Properties:  status check passed Passed #10899  •  git commit 2c40cb53c5 ℹ️: Merge 6130d4f7222444bc77f19293aa2233876c9378a1 into 8df192f4a74f0b402ee06a752d30...
Project Geotrek-admin
Branch Review refs/pull/4472/merge
Run status status check passed Passed #10899
Run duration 02m 00s
Commit git commit 2c40cb53c5 ℹ️: Merge 6130d4f7222444bc77f19293aa2233876c9378a1 into 8df192f4a74f0b402ee06a752d30...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

docs/install/upgrade.rst Outdated Show resolved Hide resolved
docs/install/upgrade.rst Outdated Show resolved Hide resolved
@@ -96,7 +96,9 @@ From Geotrek-admin < 2.113.0

Starting from version 2.113.0, Geotrek now requires pgRouting. Please follow these steps before updating.

**On a Debian packaging installation with database on same host :**
If you use Ubuntu Bionic 18.04 on your database host (on same or external geotrek-admin host), you can follow the instructions below to install PgRouting on it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you use Ubuntu Bionic 18.04 on your database host (on same or external geotrek-admin host), you can follow the instructions below to install PgRouting on it.
If you use Ubuntu Bionic 18.04 on your database host (on same or external Geotrek-admin host), you can follow the instructions below to install PgRouting on it.

docs/install/upgrade.rst Outdated Show resolved Hide resolved
@submarcos submarcos added 📝 Documentation and removed dependencies Pull requests that update a dependency file labels Jan 31, 2025
@submarcos submarcos marked this pull request as ready for review January 31, 2025 16:36
@submarcos submarcos merged commit 1c447ba into master Jan 31, 2025
19 checks passed
@submarcos submarcos deleted the improve_doc_for_pgrouting_upgrade branch January 31, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants