Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npi 3670 sp3 bugfixes and unit tests #65

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

treefern
Copy link
Collaborator

A bunch of bug fixes, unit tests, and TODOs for further work on both of these fronts.

@treefern treefern requested a review from ronaldmaj December 24, 2024 05:31
@treefern treefern self-assigned this Dec 24, 2024
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR has very minor changes so I think it can go in - I just found a typo in one of your comment blocks. Once that is fixed, happy to approve

gnssanalysis/gn_io/sp3.py Outdated Show resolved Hide resolved
gnssanalysis/gn_io/sp3.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that fix. Happy for this to go in now

@treefern treefern merged commit f96026c into main Jan 7, 2025
4 checks passed
@treefern treefern deleted the NPI-3670-sp3-bugfixes-and-unit-tests branch January 7, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants