-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npi 3670 sp3 bugfixes and unit tests #65
Conversation
…d when reading an SP3 with velocities in it. Add placeholder todo, for following up correct outputting of SP3 data with velocities
…t sees a file with EP or EV flags on a row
…s not finished yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR has very minor changes so I think it can go in - I just found a typo in one of your comment blocks. Once that is fixed, happy to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that fix. Happy for this to go in now
A bunch of bug fixes, unit tests, and TODOs for further work on both of these fronts.