NPI-3501 better empty input file checks #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- path2bytes() now raises exceptions on all errors rather than returning None. It also raises an EOFError if the input data is empty. It has also been restructured slightly for clarity and type checking. - read_sp3() now accepts a Path or bytes input, and writes an empty string into the 'path' attribute if the input was passed as bytes.
…lid file exception handling
…ile exceptions (which was the initial motivation for this whole branch).
ronaldmaj
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should help to avoid misleading downstream errors caused by empty files, which are currently not detected at the file reading stage.
path2bytes()now raises exceptions on all errors rather than returning None. It also raises anEOFErrorif the input data is empty. It has also been restructured slightly for clarity and type checking.read_sp3()now accepts aPathorbytesinput in addition to a path asstr. It now writes an empty string into the 'path' attribute if the input was passed as bytes.