Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sp3 changes + unittesting #32
Sp3 changes + unittesting #32
Changes from 16 commits
fe3b989
29be020
0b56e60
a10301a
0c68aaf
bb07e60
0c54473
948837a
8401b57
8edaade
1518b1c
5c82dd6
d89290d
de7507e
f46e274
19e6834
ce2b885
eb74bb5
9523322
fefbaba
e7a4747
0820e59
59c04f8
a8bcf60
1631d32
fe81af2
9e96872
0f9fc27
f8e6493
1dc5be6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates specification of our requirements. It's not as simple as just pointing at
requirements.txt
though, as there isn't one.Requirements are specified in
setup.py
, though that could be modified to read them from arequirements.txt
file for consistency... I prototyped that idea and it works, but it's hacky because I have to handle possible commenting. Time for me to read about the differences between setup.py and requirements.txt and how to do this properly...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output type-hint is missing here.
Also, I think @EugeneDu-GA should test any sp3 files he was having trouble with against this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this not work previously?