Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake fixes #6

Merged
merged 1 commit into from
Apr 22, 2020
Merged

CMake fixes #6

merged 1 commit into from
Apr 22, 2020

Conversation

kgerheiser
Copy link

@kgerheiser kgerheiser commented Apr 21, 2020

I would test this out. The changes are simple, but I made these changes quickly and didn't have the various libraries to build with.

Link to target instead of .a

Make shared_all's headers public

Use target_compile_definitions

Use the target's name directly. Making it a variable is kind of redundant and doesn't really save anything. We did that in some of the other builds because we looped over target names and expanded them in code.

Prefer target_include_directories rather than include_directories. Working with targets instead of global function is generally preferred.

Use target_compile_definitions
Copy link
Owner

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help. I will try this.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit e9c4ec3 into GeorgeGayno-NOAA:feature/cmake2 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants