Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would test this out. The changes are simple, but I made these changes quickly and didn't have the various libraries to build with.
Link to target instead of .a
Make shared_all's headers public
Use target_compile_definitions
Use the target's name directly. Making it a variable is kind of redundant and doesn't really save anything. We did that in some of the other builds because we looped over target names and expanded them in code.
Prefer
target_include_directories
rather thaninclude_directories
. Working with targets instead of global function is generally preferred.