-
Notifications
You must be signed in to change notification settings - Fork 75
Outsource Cython backend #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really cool to see how fast GSTools now "build" with GSTools-Cython already built. Thank you this PR and for the new Cython repo!!
Two things to think about.
-
Now that I read the installation guide again, I think that the part about building Cython with parallel support sounds pretty complicated, which it really isn't. Maybe first provide the code block and then the explanation for those who are really interested?
-
Because the Rust code runs parallel without any extra installation steps when using pip, maybe that installation guide should come before the Cython part in order to keep it as simple as possible for the users? And maybe we should tone the text down a bit. It's probably not going to completely replace the Cython code anytime soon ;-)
But apart from that, I don't see anything to complain about, so LGTM ;-)
Now that we have GSTools-Cython, we can remove the cython code from GSTools.