Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12815] Add custom login view/template to support recaptcha on Login Form (#12825) #12831

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

cmotadev
Copy link
Contributor

Fixes this Issue: Add Recaptcha Form on GeoNode Login
Originally put on 4.4.x branch, and now submitted to maste branch

Copy link

cla-bot bot commented Jan 19, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cmotadev on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (1c40f06) to head (6af3cac).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12831      +/-   ##
==========================================
- Coverage   67.95%   67.93%   -0.02%     
==========================================
  Files         975      976       +1     
  Lines       58886    58895       +9     
  Branches     6886     6886              
==========================================
- Hits        40017    40012       -5     
- Misses      17232    17246      +14     
  Partials     1637     1637              

@mattiagiupponi mattiagiupponi self-requested a review January 20, 2025 08:36
Copy link
Contributor

@mattiagiupponi mattiagiupponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is working, but can you please run black and flake8 using the master branch versions?
You can install them via pip install --upgrade $(grep 'flake8\|black' requirements.txt)
and then running black geonode && flake8 geonode

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 21, 2025
@mattiagiupponi mattiagiupponi merged commit 12ebd8c into GeoNode:master Jan 21, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Recaptcha support for GeoNode Sign-In Form
2 participants