Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11847] Implement the option to hide resources from search and… #11848

Merged
merged 9 commits into from
Jan 17, 2024

Conversation

mattiagiupponi
Copy link
Contributor

… catalogue listing

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi self-assigned this Jan 16, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 16, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Merging #11848 (db5f91e) into master (cb99e30) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 96.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11848      +/-   ##
==========================================
+ Coverage   62.99%   63.04%   +0.05%     
==========================================
  Files         876      877       +1     
  Lines       52574    52655      +81     
  Branches     6609     6616       +7     
==========================================
+ Hits        33120    33198      +78     
- Misses      17935    17937       +2     
- Partials     1519     1520       +1     

@mattiagiupponi mattiagiupponi added this to the 4.3.0 milestone Jan 17, 2024
@giohappy giohappy merged commit 5950784 into master Jan 17, 2024
9 checks passed
@giohappy giohappy deleted the ISSUE_11847 branch January 17, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the option to hide resources from search and catalogue listing
2 participants