-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #10482] Upload ISO-19115 xml metadata via the API #10483
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @ahmdthr on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Related PR to the GeoNode documentation: GeoNode/documentation#267 |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @ahmdthr on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #10483 +/- ##
==========================================
+ Coverage 61.98% 62.08% +0.09%
==========================================
Files 827 827
Lines 50952 51081 +129
Branches 6556 6561 +5
==========================================
+ Hits 31585 31714 +129
Misses 17684 17684
Partials 1683 1683 |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @ahmdthr on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Dear @ahmdthr thank you for your Pull Request. In order to be able to merge this one we need few things:
Thank you for your support! |
Hi, 1- I have sign the CLA and sent it to OSGEO already and I got the confirmation that my name has been added to the database. I hope now my PR can be merged. Thank you very much. Best regards. |
@ahmdthr very well, thanks so much. I'll take care of updating both the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good, but we are missing the permissions checks on the resource.
The @action
should contain a permission_classes
list like the following one (and the tests should prove this is actually working):
permission_classes=[
IsAuthenticated, UserHasPerms(
perms_dict={
"default": {
"PUT": ['base.change_resourcebase_metadata']
}
}
)
])
* ISO-19115 xml metadata file can be uploaded via the API * Small changes for PEP8 compliance * Added tests for checking permissions for metadata upload Co-authored-by: Alessio Fabiani <[email protected]> (cherry picked from commit 153736b)
…0548) * ISO-19115 xml metadata file can be uploaded via the API * Small changes for PEP8 compliance * Added tests for checking permissions for metadata upload Co-authored-by: Alessio Fabiani <[email protected]> (cherry picked from commit 153736b) Co-authored-by: ahmdthr <[email protected]>
References: #10482
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.