Skip to content

Commit

Permalink
Fixed Save/Save As plugin permissions (#884)
Browse files Browse the repository at this point in the history
  • Loading branch information
DavidQuartz authored Mar 18, 2022
1 parent d4b0dce commit 6b31011
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
5 changes: 3 additions & 2 deletions geonode_mapstore_client/client/js/plugins/SaveAs.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,9 @@ const ConnectedSaveAsButton = connect(
canAddResource,
getResourceData,
getResourceDirtyState,
(loggedIn, userCanAddResource, resource, dirtyState) => ({
enabled: loggedIn && userCanAddResource && resource?.is_copyable,
isNewResource,
(loggedIn, userCanAddResource, resource, dirtyState, isResourceNew) => ({
enabled: loggedIn && userCanAddResource && (resource?.is_copyable || isResourceNew),
resource,
disabled: !!dirtyState
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@
{
"labelId": "gnviewer.save",
"showPendingChangesIcon": true,
"disableIf": "{!context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"disableIf": "{!state('isNewResource') && !context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"type": "dropdown",
"items": [
{
Expand Down Expand Up @@ -1638,7 +1638,7 @@
{
"labelId": "gnviewer.save",
"showPendingChangesIcon": true,
"disableIf": "{!context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"disableIf": "{!state('isNewResource') && !context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"type": "dropdown",
"items": [
{
Expand Down Expand Up @@ -2174,7 +2174,7 @@
{
"labelId": "gnviewer.save",
"showPendingChangesIcon": true,
"disableIf": "{!context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"disableIf": "{!state('isNewResource') && !context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"type": "dropdown",
"items": [
{
Expand All @@ -2190,7 +2190,7 @@
{
"name": "Sync",
"type": "plugin",
"disableIf": "{!context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase')}"
"disableIf": "{!context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase')}"
},
{
"labelId": "gnviewer.edit",
Expand Down Expand Up @@ -2468,7 +2468,7 @@
"labelId": "gnviewer.save",
"type": "dropdown",
"showPendingChangesIcon": true,
"disableIf": "{!state('isNewResource') && !context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase')}",
"disableIf": "{!state('isNewResource') && !context.resourceHasPermission(state('gnResourceData'), 'change_resourcebase') && !context.canCopyResource(state('gnResourceData'), state('user'))}",
"items": [
{
"type": "plugin",
Expand Down

0 comments on commit 6b31011

Please sign in to comment.