-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from versioneer to setuptools-scm #695
Conversation
Replace versioneer added in 3683f37 with the more modern [setuptools-scm](https://github.com/pypa/setuptools_scm).
a8ff2ff
to
83a0c49
Compare
setup.py
Outdated
SETUP_REQUIRES = ["setuptools_scm"] | ||
USE_SCM_VERSION = { | ||
"local_scheme": "node-and-date", | ||
"write_to": "_version.py", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if writing to a _version.py
file is actually needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/fatiando/boule doesn't write the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll remove this line then (and don't add _version.py
to .gitignore too).
This reverts commit 8ac4cd3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description of proposed changes
Replace versioneer added in 3683f37 with the more modern setuptools-scm.
This PR mostly follows psf/black#1008, and fatiando/boule#61:
There is a_version.py
file at the top-level which is git-ignored that contains a single line like__version__ = "0.2.2.dev3+g355d85f1"
What this PR doesn't do:
Fixes #671
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Notes
/format
in the first line of a comment to lint the code automatically