Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-legend feature to grdcontour and contour #568

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Add auto-legend feature to grdcontour and contour #568

merged 1 commit into from
Aug 20, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 19, 2020 •
edited
Loading

Description of proposed changes

Add label argument to Figure.grdcontour() and Figure.contour().

Fixes #565

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman requested a review from weiji14 August 19, 2020 19:27
@seisman seisman added the enhancement Improving an existing feature label Aug 19, 2020
@seisman seisman added this to the 0.2.x milestone Aug 20, 2020
@seisman seisman merged commit ae92da2 into master Aug 20, 2020
@seisman seisman deleted the contour-label branch August 20, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
enhancement Improving an existing feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Add auto-lable (-l) to grdcontour and contour
2 participants
@seisman @weiji14