-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fatiando continuous integration scripts from 1.1.1 to 1.2.0 #355
Conversation
Fixes randomly failing Mac builds. See release notes at https://github.com/fatiando/continuous-integration/releases/tag/1.2.0.
@leouieda, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiji14 sorry, that PR wasn't very clear. Upgrading the scripts isn't enough. You have to add this block to all Azure Mac build configurations: https://github.com/fatiando/continuous-integration/pull/19/files#diff-79a889188c51195ad1884f90e264f03cR43
Ah yes that makes sense, I saw that code block but thought it runs inside the CI script. Things should work now 🤞 |
@weiji14 on a separate note, feel free to create branches on the main repository for your pull requests (instead of using your fork). It makes it easier to keep the master branch updated. You've earned it 👍 |
I'd love to but can't... As mentioned in #317, there's something about GMT organization's permissions that's stopping me from pushing or creating branches directly here. |
@weiji14 could you try again? That's not right and we should get this sorted. |
Nope, still not working 😢 I reckon it's my two factor authentication that's the problem, am I the only one in GMT using it? Look at https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/viewing-whether-users-in-your-organization-have-2fa-enabled |
It shouldn't be because I've had that on for years now. |
I just tripple checked and you're part of the |
Ok, not sure what happened, but I can push to and create branches on GenericMappingTools repos properly now, including branches on the FOSS4G 2019 Oceania repo! And that's via SSH as well. Did you change something? |
Description of proposed changes
Fixes randomly failing Mac builds. See release notes at https://github.com/fatiando/continuous-integration/releases/tag/1.2.0.
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.