Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing mpl_image_compare mark to test_plot_dataframe_incols #2287

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 30, 2022

Description of proposed changes

Fix the following error shown in the CI runs:

pygmt/tests/test_plot.py::test_plot_dataframe_incols
  /usr/share/miniconda3/envs/pygmt/lib/python3.8/site-packages/_pytest/python.py:199: PytestReturnNotNoneWarning: Expected None, but pygmt/tests/test_plot.py::test_plot_dataframe_incols returned <pygmt.figure.Figure object at 0x7fb2c5134520>, which will be an error in a future version of pytest.  Did you mean to use `assert` instead of `return`?
    warnings.warn(

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 30, 2022
@seisman seisman added this to the 0.9.0 milestone Dec 30, 2022
@seisman seisman merged commit 6072b00 into main Dec 30, 2022
@seisman seisman deleted the test_plot_dataframe_incols branch December 30, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants